Added `Clone` implementation for `ChunkBy` #138016

nwoods-cimpress · 2025-03-04T21:42:36Z

Added Clone implementation for ChunkBy

rustbot · 2025-03-04T21:42:41Z

rustbot has assigned @Noratrieb.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

thaliaarchi · 2025-03-04T23:54:16Z

library/core/src/slice/iter.rs

@@ -3372,6 +3372,13 @@ where
 #[stable(feature = "slice_group_by", since = "1.77.0")]
 impl<'a, T: 'a, P> FusedIterator for ChunkBy<'a, T, P> where P: FnMut(&T, &T) -> bool {}

+#[stable(feature = "slice_group_by", since = "1.77.0")]


You'll need a new feature name with the version CURRENT_RUSTC_VERSION in since.

@thaliaarchi i think i got it 🤞 , bear with me if i made a newbie mistake

Well it looks good to me! I’m not in a Rust team, so my approval doesn’t mean anything, but you should hear back from someone within two weeks.

compiler-errors · 2025-03-05T05:44:14Z

should get a t-libs-api reviewer

r? libs-api

compiler-errors · 2025-03-05T05:46:31Z

cc:

Tracking Issue for the GroupBy and GroupByMut iterators #80552 (tracking issue)
The return of the GroupBy and GroupByMut iterators on slice #79895 (initial PR)
Stabilize slice_group_by #117678 (stabilization PR)

No mention of Clone as far as I can see, so perhaps this was just an oversight?

bors · 2025-03-08T16:31:56Z

☔ The latest upstream changes (presumably #138208) made this pull request unmergeable. Please resolve the merge conflicts.

m-ou-se · 2025-03-18T14:42:38Z

@rfcbot merge

rfcbot · 2025-03-18T14:42:40Z

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

datdenkikniet · 2025-03-30T19:47:29Z

Just to make sure that the relevant issue is tracked/closed once this is fully merged & done: this PR fixes #137969

nwoods-cimpress · 2025-05-30T20:18:18Z

Got to ask, its been two months. Is there anything that needs to happen to move this PR forward?

dtolnay · 2025-05-30T20:58:09Z

It is waiting on an approval by at least one of @Amanieu or @BurntSushi or @joshtriplett.

rfcbot · 2025-06-01T12:33:17Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot · 2025-06-11T12:35:36Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

dtolnay

Thanks!

dtolnay · 2025-06-11T16:01:51Z

@bors r+

bors · 2025-06-11T16:01:54Z

📌 Commit e48617f has been approved by dtolnay

It is now in the queue for this repository.

…e, r=dtolnay Added `Clone` implementation for `ChunkBy` Added `Clone` implementation for `ChunkBy` Closes rust-lang#137969.

Rollup of 9 pull requests Successful merges: - #138016 (Added `Clone` implementation for `ChunkBy`) - #140770 (add `extern "custom"` functions) - #141162 (refactor `AttributeGate` and `rustc_attr!` to emit notes during feature checking) - #141474 (Add `ParseMode::Diagnostic` and fix multiline spans in diagnostic attribute lints) - #141947 (Specify that "option-like" enums must be `#[repr(Rust)]` to be ABI-compatible with their non-1ZST field.) - #142135 (docs: autogenerate compiler flag stubs based on -Zhelp) - #142252 (Improve clarity of `core::sync::atomic` docs about "Considerations" in regards to CAS operations) - #142337 (miri: add flag to suppress float non-determinism) - #142353 (compiler: Ease off the accelerator on `unsupported_calling_conventions`) r? `@ghost` `@rustbot` modify labels: rollup

…e, r=dtolnay Added `Clone` implementation for `ChunkBy` Added `Clone` implementation for `ChunkBy` Closes rust-lang#137969.

Rollup of 8 pull requests Successful merges: - #138016 (Added `Clone` implementation for `ChunkBy`) - #140770 (add `extern "custom"` functions) - #141162 (refactor `AttributeGate` and `rustc_attr!` to emit notes during feature checking) - #141474 (Add `ParseMode::Diagnostic` and fix multiline spans in diagnostic attribute lints) - #141947 (Specify that "option-like" enums must be `#[repr(Rust)]` to be ABI-compatible with their non-1ZST field.) - #142252 (Improve clarity of `core::sync::atomic` docs about "Considerations" in regards to CAS operations) - #142337 (miri: add flag to suppress float non-determinism) - #142353 (compiler: Ease off the accelerator on `unsupported_calling_conventions`) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned Noratrieb Mar 4, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 4, 2025

nwoods-cimpress mentioned this pull request Mar 4, 2025

std::slice::ChunkBy should implement Clone #137969

Open

thaliaarchi suggested changes Mar 4, 2025

View reviewed changes

rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Mar 5, 2025

rustbot assigned joshtriplett and unassigned Noratrieb Mar 5, 2025

compiler-errors added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Mar 5, 2025

thaliaarchi approved these changes Mar 6, 2025

View reviewed changes

rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 10, 2025

This comment has been minimized.

Sign in to view

nwoods-cimpress added 2 commits March 10, 2025 11:12

Added Clone implementation for ChunkBy

8bbc080

Changing #[stable] tag

e48617f

nwoods-cimpress force-pushed the slice_chunkby_clone branch from d71ca93 to e48617f Compare March 10, 2025 15:14

rustbot removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 10, 2025

rfcbot added the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Mar 18, 2025

rfcbot added the disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. label Mar 18, 2025

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jun 1, 2025

rustbot mentioned this pull request Jun 11, 2025

Tracking issue for release notes of #138016: Added Clone implementation for ChunkBy #142363

Open

dtolnay approved these changes Jun 11, 2025

View reviewed changes

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 11, 2025

workingjubilee mentioned this pull request Jun 12, 2025

Rollup of 15 pull requests #142396

Closed

workingjubilee mentioned this pull request Jun 12, 2025

Rollup of 15 pull requests #142397

Open

matthiaskrgr mentioned this pull request Jun 12, 2025

Rollup of 9 pull requests #142399

Closed

matthiaskrgr mentioned this pull request Jun 12, 2025

Rollup of 8 pull requests #142409

Open

Added Clone implementation for ChunkBy #138016

Are you sure you want to change the base?

Added Clone implementation for ChunkBy #138016

Conversation

nwoods-cimpress commented Mar 4, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Mar 4, 2025

Uh oh!

thaliaarchi Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

nwoods-cimpress Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

thaliaarchi Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

compiler-errors commented Mar 5, 2025

Uh oh!

compiler-errors commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Mar 8, 2025

Uh oh!

This comment has been minimized.

m-ou-se commented Mar 18, 2025

Uh oh!

rfcbot commented Mar 18, 2025 • edited by BurntSushi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

datdenkikniet commented Mar 30, 2025

Uh oh!

nwoods-cimpress commented May 30, 2025

Uh oh!

dtolnay commented May 30, 2025

Uh oh!

rfcbot commented Jun 1, 2025

Uh oh!

rfcbot commented Jun 11, 2025

Uh oh!

dtolnay left a comment

Choose a reason for hiding this comment

Uh oh!

dtolnay commented Jun 11, 2025

Uh oh!

bors commented Jun 11, 2025

Uh oh!

Uh oh!

Added `Clone` implementation for `ChunkBy` #138016

Added `Clone` implementation for `ChunkBy` #138016

nwoods-cimpress commented Mar 4, 2025 •

edited by rustbot

Loading

compiler-errors commented Mar 5, 2025 •

edited

Loading

rfcbot commented Mar 18, 2025 •

edited by BurntSushi

Loading